Conversation
j-c-c
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1344 +/- ##
========================================
Coverage 90.65% 90.65%
========================================
Files 134 134
Lines 14430 14430
========================================
Hits 13082 13082
Misses 1348 1348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
The CI issues encountered here were not related to the changes in this PR (conda/infrastructure#1254) and appear to have resolved. I ended up bumping the scipy version for the optimized environments in the course of trying to understand the failures. Might be good to leave that version since it's release date is closer to the updated numpy version. |
Collaborator
Author
|
@garrettwrong this is ready for review |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #1343
Setting this as "ready to review" to run the conda-build jobs.